fix(Slider): export function for preparing initial value #1637
Conversation
| @@ -88,7 +88,7 @@ function createMarks(points: number[]): RcSliderProps['marks'] { | |||
| return marks; | |||
| } | |||
|
|
|||
| export function getInnerState({ | |||
| export function prepareSliderInnerState({ | |||
There was a problem hiding this comment.
Could you provide some jsdoc here?
There was a problem hiding this comment.
Yes, forgot to do it, thanks
143584f
|
Preview is ready. |
|
Visual Tests Report is ready. |
amje
changed the title
| @@ -88,7 +88,7 @@ function createMarks(points: number[]): RcSliderProps['marks'] { | |||
| return marks; | |||
| } | |||
|
|
|||
| export function getInnerState({ | |||
| export function prepareSliderInnerState({ | |||
There was a problem hiding this comment.
Why user might needed this function?
There was a problem hiding this comment.
Why user might needed this function?
I need it to use in RangeSliderPicker component to get inner state. And I don't want to duplicate the code.
Also it could be helpful for other users in the development of components based on the slider.
There was a problem hiding this comment.
@amje, I don't know is it really "fix" but not "chore"?
Is it important enough to get into the changelog?
There was a problem hiding this comment.
Yes, it's important to note this change in the changelog because you have changed the implementation
-small refactor of initial value function
-add prepareSliderInnerState function to export